From: Tom Lane <tgl@sss.pgh.pa.us>
To: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-hackers@postgreSQL.org
Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
Date: Thu, 22 Jan 2009 18:27:47 -0500
Message-ID: <20643.1232666867@sss.pgh.pa.us> (raw)
In-Reply-To: <20090122100948.89F977559ED@cvs.postgresql.org>
References: <20090122100948.89F977559ED@cvs.postgresql.org>
mha@postgresql.org (Magnus Hagander) writes:
> Explicitly bind gettext to the correct encoding on Windows.
I have a couple of objections to this patch. First, what happens if
it fails to find a matching table entry? (The existing answer is
"nothing", but that doesn't seem right.) Second and more critical,
it adds still another data structure that has to be maintained when
the list of encodings changes, and it doesn't even live in the same
file as any existing encoding-information table.
What makes more sense to me is to add a table to encnames.c that
provides the gettext name of every encoding that we support.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, magnus@hagander.net, pgsql-hackers@postgreSQL.org
Subject: Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
In-Reply-To: <20643.1232666867@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox