From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Convert some extern variables to static
Date: Thu, 19 Sep 2024 19:15:28 -0400
Message-ID: <2078838.1726787728@sss.pgh.pa.us> (raw)
In-Reply-To: <E1sOW2T-003tAa-EP@gemulon.postgresql.org>
References: <E1sOW2T-003tAa-EP@gemulon.postgresql.org>
Peter Eisentraut <peter@eisentraut.org> writes:
> Convert some extern variables to static
I'm surprised it took me so long to notice, but this commit
makes headerscheck unhappy:
$ src/tools/pginclude/headerscheck
In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/EAN13.h:26:20: warning: 'EAN13_range' defined but not used [-Wunused-variable]
static const char *EAN13_range[][2] = {
^~~~~~~~~~~
In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/ISBN.h:983:20: warning: 'ISBN_range_new' defined but not used [-Wunused-variable]
static const char *ISBN_range_new[][2] = {
^~~~~~~~~~~~~~
./contrib/isn/ISBN.h:50:20: warning: 'ISBN_range' defined but not used [-Wunused-variable]
static const char *ISBN_range[][2] = {
^~~~~~~~~~
In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/ISMN.h:45:20: warning: 'ISMN_range' defined but not used [-Wunused-variable]
static const char *ISMN_range[][2] = {
^~~~~~~~~~
In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/ISSN.h:46:20: warning: 'ISSN_range' defined but not used [-Wunused-variable]
static const char *ISSN_range[][2] = {
^~~~~~~~~~
In file included from /tmp/headerscheck.40tbNq/test.c:2:
./contrib/isn/UPC.h:26:20: warning: 'UPC_range' defined but not used [-Wunused-variable]
static const char *UPC_range[][2] = {
^~~~~~~~~
We could either revert the static-ification of these variables,
or move them into isn.c which seems to be the sole consumer.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Convert some extern variables to static
In-Reply-To: <2078838.1726787728@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox