agora inbox for pgsql-committers@postgresql.org  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve
Date: Wed, 12 Oct 2016 14:56:29 -0400
Message-ID: <20952.1476298589@sss.pgh.pa.us> (raw)
In-Reply-To: <c0af8add-2bf6-1e28-bb7a-1872aef2b043@2ndquadrant.com>
References: <E1buMGV-0002WG-AJ@gemulon.postgresql.org>
	<c0af8add-2bf6-1e28-bb7a-1872aef2b043@2ndquadrant.com>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 10/12/16 12:20 PM, Tom Lane wrote:
>> Remove pg_dump/pg_dumpall support for dumping from pre-8.0 servers.

> It looks like this or a related commit has caused these compiler warnings:

> pg_dump.c: In function 'getTypes':
> pg_dump.c:3692:8: error: variable 'i_typoutput' set but not used
> [-Werror=unused-but-set-variable]
>   int   i_typoutput;
>         ^~~~~~~~~~~
> pg_dump.c:3691:8: error: variable 'i_typinput' set but not used
> [-Werror=unused-but-set-variable]
>   int   i_typinput;
>         ^~~~~~~~~~

Ah, I'd not noticed because my compiler doesn't complain.
Will fix, thanks.

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (5+ messages)  latest in thread

Message-ID: <20952.1476298589@sss.pgh.pa.us>
Permalink:  ../20952.1476298589@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20952.1476298589@sss.pgh.pa.us

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com
  Subject: Re: pgsql: Remove pg_dump/pg_dumpall support for dumping from pre-8.0 serve
  In-Reply-To: <20952.1476298589@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox