From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org, Michael Paquier <michael@paquier.xyz>
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Date: Mon, 20 Sep 2021 21:32:09 -0700
Message-ID: <216D2155-018C-4FFB-8FE3-73CAA5A3FEE1@anarazel.de> (raw)
In-Reply-To: <YUlVzPkVgEPjtmIB@paquier.xyz>
References: <E1mQglq-0007xB-Jw@gemulon.postgresql.org>
<20210921032040.lyl4lcax37aedx2x@alap3.anarazel.de>
<YUlVzPkVgEPjtmIB@paquier.xyz>
Hi,
On September 20, 2021 8:47:24 PM PDT, Michael Paquier <michael@paquier.xyz> wrote:
>On Mon, Sep 20, 2021 at 08:20:40PM -0700, Andres Freund wrote:
>> So the problem is that -C data_checksums requires permissions to be dropped,
>> but the way it's invoked here that's not guaranteed... And I don't think we
>> should remove that requirement, given that we're actually doing stuff to the
>> lock file...
>
>Hmm. One way I can think of to keep the test would be something like
>that to avoid problems with pg_ctl redirecting the server's stderr to
>stdout (hence the tweak for log_min_messages):
>pg_ctl start -s -o '-C data_checksums -c log_min_messages=fatal'
Yes, that should work. Although error should suffice.
FWIW, I think it'd be good to hide that message in the -C case.
>This would print the parameter, while getting to stderr mostly a
>"could not start server". Would that work for you?
Yes, I think so.
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, michael@paquier.xyz
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
In-Reply-To: <216D2155-018C-4FFB-8FE3-73CAA5A3FEE1@anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox