From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
Date: Tue, 21 Sep 2021 12:47:24 +0900
Message-ID: <YUlVzPkVgEPjtmIB@paquier.xyz> (raw)
In-Reply-To: <20210921032040.lyl4lcax37aedx2x@alap3.anarazel.de>
References: <E1mQglq-0007xB-Jw@gemulon.postgresql.org>
<20210921032040.lyl4lcax37aedx2x@alap3.anarazel.de>
On Mon, Sep 20, 2021 at 08:20:40PM -0700, Andres Freund wrote:
> So the problem is that -C data_checksums requires permissions to be dropped,
> but the way it's invoked here that's not guaranteed... And I don't think we
> should remove that requirement, given that we're actually doing stuff to the
> lock file...
Hmm. One way I can think of to keep the test would be something like
that to avoid problems with pg_ctl redirecting the server's stderr to
stdout (hence the tweak for log_min_messages):
pg_ctl start -s -o '-C data_checksums -c log_min_messages=fatal'
This would print the parameter, while getting to stderr mostly a
"could not start server". Would that work for you?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Support "postgres -C" with runtime-computed GUCs
In-Reply-To: <YUlVzPkVgEPjtmIB@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox