From: Alexander Lakhin <exclusion@gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Update obsolete index scan TID comments.
Date: Fri, 17 May 2024 13:00:00 +0300
Message-ID: <21c7267f-c27b-af5a-2c61-8777098587cb@gmail.com> (raw)
In-Reply-To: <E1rjnnt-003JwC-A9@gemulon.postgresql.org>
References: <E1rjnnt-003JwC-A9@gemulon.postgresql.org>
Hello Peter,
12.03.2024 01:07, Peter Geoghegan wrote:
> Update obsolete index scan TID comments.
>
> Oversight in commit c2fe139c20.
I found one more obsolete comment mentioning xs_ctup:
/*
* For IndexOnlyScan, the tuple stored in ss_ScanTupleSlot may be
* a virtual tuple that does not have the ctid column, so we have
* to get the TID from xs_ctup.t_self.
*/
IndexScanDesc scan = ((IndexOnlyScanState *) scanstate)->ioss_ScanDesc;
*current_tid = scan->xs_heaptid;
Maybe you would like to fix it too...
Best regards,
Alexander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: exclusion@gmail.com, pg@bowt.ie, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Update obsolete index scan TID comments.
In-Reply-To: <21c7267f-c27b-af5a-2c61-8777098587cb@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox