pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
Date: Wed, 20 Oct 2021 17:48:39 -0400
Message-ID: <2276280.1634766519@sss.pgh.pa.us> (raw)
In-Reply-To: <d6fe7d77-314c-0332-209f-b1294424d37d@dunslane.net>
References: <202110181423.cmd34pruwlry@alvherre.pgsql>
	<ffca3f20-e0ed-5328-7793-cffe9cb7d59f@dunslane.net>
	<20211020163123.adogznqee7oosvj5@alap3.anarazel.de>
	<1ccbc9a2-1e0f-93bf-745d-99b3409e10ae@dunslane.net>
	<20211020190916.bzvnmo6kxeqehczv@alap3.anarazel.de>
	<d6fe7d77-314c-0332-209f-b1294424d37d@dunslane.net>

Andrew Dunstan <andrew@dunslane.net> writes:
> OK, it turns out that it's better to put the addition at the end of the
> PATH, otherise initdb complains that it can't find postgres in the same
> directory.

That seems horribly unsafe, or at least prone to pulling in the
program from some other versuion of Postgres.  How about ordering
the path like

PATH="$(abs_top_builddir)/tmp_install$(bindir):$(CURDIR):$$PATH"

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <2276280.1634766519@sss.pgh.pa.us>
Permalink:  ../2276280.1634766519@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2276280.1634766519@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, andres@anarazel.de, alvherre@alvh.no-ip.org
  Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
  In-Reply-To: <2276280.1634766519@sss.pgh.pa.us>
  References: <202110181423.cmd34pruwlry@alvherre.pgsql> <ffca3f20-e0ed-5328-7793-cffe9cb7d59f@dunslane.net> <20211020163123.adogznqee7oosvj5@alap3.anarazel.de> <1ccbc9a2-1e0f-93bf-745d-99b3409e10ae@dunslane.net> <20211020190916.bzvnmo6kxeqehczv@alap3.anarazel.de> <d6fe7d77-314c-0332-209f-b1294424d37d@dunslane.net> <2276280.1634766519@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox