pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move I/O before the index_update_stats() buffer lock region.
Date: Sat, 02 Nov 2024 22:32:56 -0400
Message-ID: <2317336.1730601176@sss.pgh.pa.us> (raw)
In-Reply-To: <E1t7GgB-003cVa-Th@gemulon.postgresql.org>
References: <E1t7GgB-003cVa-Th@gemulon.postgresql.org>

Noah Misch <noah@leadboat.com> writes:
> Move I/O before the index_update_stats() buffer lock region.

In branches before 17, this commit is causing some compilers
to complain:

index.c: In function 'index_update_stats':
index.c:2913:24: warning: 'relpages' may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (rd_rel->relpages != (int32) relpages)
       ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~

I'm seeing that with RHEL8's gcc 8.5.0, and trawling the buildfarm
shows at least 40 animals similarly unhappy.  (I noticed this because
mamba, which is using -Werror, is actually failing.)

			regards, tom lane





view thread (11+ messages)  latest in thread

Message-ID: <2317336.1730601176@sss.pgh.pa.us>
Permalink:  ../2317336.1730601176@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2317336.1730601176@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Move I/O before the index_update_stats() buffer lock region.
  In-Reply-To: <2317336.1730601176@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox