pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Remove BufFile's isTemp flag.
Date: Thu, 16 Nov 2017 21:58:14 -0500
Message-ID: <23339.1510887494@sss.pgh.pa.us> (raw)
In-Reply-To: <E1eFVyl-0008J1-RO@gemulon.postgresql.org>
References: <E1eFVyl-0008J1-RO@gemulon.postgresql.org>

Andres Freund <andres@anarazel.de> writes:
> Remove BufFile's isTemp flag.
> The isTemp flag controls whether buffile.c chops BufFile data up into
> 1GB segments on disk.  Since it was badly named and always true, get
> rid of it.

[ squint... ]  That used to have an actual purpose connected to
transaction-abort cleanup, IIRC.  It disturbs me that this seems
to have been lost.

			regards, tom lane




view thread (13+ messages)  latest in thread

Message-ID: <23339.1510887494@sss.pgh.pa.us>
Permalink:  ../23339.1510887494@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/23339.1510887494@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: pgsql: Remove BufFile's isTemp flag.
  In-Reply-To: <23339.1510887494@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox