From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix compiler warning
Date: Fri, 6 Sep 2019 11:47:48 +0200
Message-ID: <23add00c-9eff-edc4-5a63-28627cbf19d1@2ndquadrant.com> (raw)
In-Reply-To: <20796.1567692924@sss.pgh.pa.us>
References: <E1i4XIR-0006li-3c@gemulon.postgresql.org>
<20190902010409.GC1841@paquier.xyz>
<e4e060b8-d4d8-28e7-4221-3967b8adb830@2ndquadrant.com>
<20190902080326.GB25912@paquier.xyz>
<5c927b9b-0000-ce62-6a18-1e0ed825c5c4@2ndquadrant.com>
<20796.1567692924@sss.pgh.pa.us>
On 2019-09-05 16:15, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> The tree currently does not compile without warnings on Windows (for
>> me), so it doesn't seem worth fixing warnings piece by piece in the
>> backbranches.
>
> Hm, I see no warnings on e.g. dory. What are you seeing, and with
> what toolchain? (Or should I be asking about build options?)
I'm using mingw here, so see jacana. The MSVC tool chain apparently
does not produce warnings about unused stuff, so this patch isn't of
relevance there.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix compiler warning
In-Reply-To: <23add00c-9eff-edc4-5a63-28627cbf19d1@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox