From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Make new strings more alike previously existing messages.
Date: Mon, 13 Apr 2009 18:57:00 -0400
Message-ID: <24097.1239663420@sss.pgh.pa.us> (raw)
In-Reply-To: <20090413210336.300427540F4@cvs.postgresql.org>
References: <20090413210336.300427540F4@cvs.postgresql.org>
alvherre@postgresql.org (Alvaro Herrera) writes:
> Make new strings more alike previously existing messages.
This patch changed the meaning of one of the messages:
*************** main(int argc, char **argv)
*** 316,322 ****
/* Can't do single-txn mode with multiple connections */
if (opts->single_txn && opts->number_of_jobs > 1)
{
! fprintf(stderr, _("%s: cannot specify both --single-transaction and multiple jobs\n"),
progname);
exit(1);
}
--- 316,322 ----
/* Can't do single-txn mode with multiple connections */
if (opts->single_txn && opts->number_of_jobs > 1)
{
! fprintf(stderr, _("%s: options -1/--single-transaction and -j/--jobs cannot be used together\n"),
progname);
exit(1);
}
As the comment and the code itself show, "-j 1" works just fine with
--single-transaction. The original wording reflected that, the new does
not.
Maybe this amount of imprecision is acceptable, but "make it look more
like the other messages" doesn't seem to me like enough justification.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@commandprompt.com
Subject: Re: pgsql: Make new strings more alike previously existing messages.
In-Reply-To: <24097.1239663420@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox