From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Unstable tests for recovery conflict handling
Date: Tue, 26 Jul 2022 13:57:53 -0400
Message-ID: <2454340.1658858273@sss.pgh.pa.us> (raw)
In-Reply-To: <447238.1651082925@sss.pgh.pa.us>
References: <E1nca5h-000nN0-6f@gemulon.postgresql.org>
<394950.1651077914@sss.pgh.pa.us>
<447238.1651082925@sss.pgh.pa.us>
I wrote:
>> It's been kind of hidden by other buildfarm noise, but
>> 031_recovery_conflict.pl is not as stable as it should be [1][2][3][4].
> After digging around in the code, I think this is almost certainly
> some manifestation of the previously-complained-of problem [1] that
> RecoveryConflictInterrupt is not safe to call in a signal handler,
> leading the conflicting backend to sometimes decide that it's not
> the problem.
I happened to notice that while skink continues to fail off-and-on
in 031_recovery_conflict.pl, the symptoms have changed! What
we're getting now typically looks like [1]:
[10:45:11.475](0.023s) ok 14 - startup deadlock: lock acquisition is waiting
Waiting for replication conn standby's replay_lsn to pass 0/33FB8B0 on primary
done
timed out waiting for match: (?^:User transaction caused buffer deadlock with recovery.) at t/031_recovery_conflict.pl line 367.
where absolutely nothing happens in the standby log, until we time out:
2022-07-24 10:45:11.452 UTC [1468367][client backend][2/4:0] LOG: statement: SELECT * FROM test_recovery_conflict_table2;
2022-07-24 10:45:11.472 UTC [1468547][client backend][3/2:0] LOG: statement: SELECT 'waiting' FROM pg_locks WHERE locktype = 'relation' AND NOT granted;
2022-07-24 10:48:15.860 UTC [1468362][walreceiver][:0] FATAL: could not receive data from WAL stream: server closed the connection unexpectedly
So this is not a case of RecoveryConflictInterrupt doing the wrong thing:
the startup process hasn't detected the buffer conflict in the first
place. Don't know what to make of that, but I vaguely suspect a test
timing problem. gull has shown this once as well, although at a different
step in the script [2].
regards, tom lane
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=skink&dt=2022-07-24%2007%3A00%3A29
[2] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gull&dt=2022-07-23%2009%3A34%3A54
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com, melanieplageman@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Unstable tests for recovery conflict handling
In-Reply-To: <2454340.1658858273@sss.pgh.pa.us>
References: <E1nca5h-000nN0-6f@gemulon.postgresql.org> <394950.1651077914@sss.pgh.pa.us> <447238.1651082925@sss.pgh.pa.us> <2454340.1658858273@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox