From: Erik Rijkers <er@xs4all.nl>
To: Amit Langote <amitlan@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add basic JSON_TABLE() functionality
Date: Thu, 4 Apr 2024 14:30:31 +0200
Message-ID: <254b2fa2-2f6b-a30a-20ee-21f8a2c12a50@xs4all.nl> (raw)
In-Reply-To: <E1rsL9y-000S60-Pn@gemulon.postgresql.org>
References: <E1rsL9y-000S60-Pn@gemulon.postgresql.org>
Op 4/4/24 om 13:21 schreef Amit Langote:
> Add basic JSON_TABLE() functionality
>
Great that it's now committed. Congrats!
There is one 'uninitialized' muttering during compile (gcc 13.2.0):
In function ‘transformJsonFuncExpr’,
inlined from ‘transformExprRecurse’ at parse_expr.c:373:13:
parse_expr.c:4317:34: warning: ‘default_format’ may be used
uninitialized [-Wmaybe-uninitialized]
4317 | jsexpr->formatted_expr = transformJsonValueExpr(pstate,
func_name,
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4318 |
func->context_item,
|
~~~~~~~~~~~~~~~~~~~
4319 |
default_format,
|
~~~~~~~~~~~~~~~
4320 |
JSONBOID,
|
~~~~~~~~~
4321 |
false);
|
~~~~~~
parse_expr.c: In function ‘transformExprRecurse’:
parse_expr.c:4257:24: note: ‘default_format’ was declared here
4257 | JsonFormatType default_format;
| ^~~~~~~~~~~~~~
Thanks!
Erik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: er@xs4all.nl, amitlan@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add basic JSON_TABLE() functionality
In-Reply-To: <254b2fa2-2f6b-a30a-20ee-21f8a2c12a50@xs4all.nl>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox