From: Andrew Dunstan <andrew@dunslane.net>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Expand AclMode to 64 bits
Date: Fri, 25 Nov 2022 09:00:20 -0500
Message-ID: <25eb9e88-2025-458c-2330-7fd5a56cbfcd@dunslane.net> (raw)
In-Reply-To: <CA+HiwqHbv4xQd-yHx0LWA04AybA+GQPy66UJxt8m32gB6zCYQQ@mail.gmail.com>
References: <E1oxvf9-000XEs-No@gemulon.postgresql.org>
<Y369jSwDb3/uzmM+@paquier.xyz>
<7550ef36-4ec2-7b03-0671-0a88aab61ce7@dunslane.net>
<CA+HiwqHbv4xQd-yHx0LWA04AybA+GQPy66UJxt8m32gB6zCYQQ@mail.gmail.com>
On 2022-11-25 Fr 01:52, Amit Langote wrote:
> Hi Andrew,
>
> On Thu, Nov 24, 2022 at 10:18 AM Andrew Dunstan <andrew@dunslane.net> wrote:
>> On 2022-11-23 We 19:40, Michael Paquier wrote:
>>> Hi Andrew,
>>>
>>> On Wed, Nov 23, 2022 at 07:44:04PM +0000, Andrew Dunstan wrote:
>>>> Expand AclMode to 64 bits
>>>>
>>>> We're running out of bits for new permissions. This change doubles the
>>>> number of permissions we can accomodate from 16 to 32, so the
>>>> forthcoming new ones for vacuum/analyze don't exhaust the pool.
>>>>
>>>> Nathan Bossart
>>>>
>>>> Reviewed by: Bharath Rupireddy, Kyotaro Horiguchi, Stephen Frost, Robert
>>>> Haas, Mark Dilger, Tom Lane, Corey Huinker, David G. Johnston, Michael
>>>> Paquier.
>>> crake is complaining for the upgrades from v12:
>>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=crake&dt=2022-11-23%2023%3A32%3A04
>>>
>>> It seems that there are some tables dependent on aclitem, bumping on
>>> your incompatible change.
>> Yeah, testing a fix for it, thanks.
> Not sure if it is related to the above, but I noticed a problem when
> rebasing my patch that moves requiredPerms out of RangeTblEntry. I
> think the commit may have missed doing the following (diff attached):
pushed, thanks.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, amitlangote09@gmail.com, michael@paquier.xyz
Subject: Re: pgsql: Expand AclMode to 64 bits
In-Reply-To: <25eb9e88-2025-458c-2330-7fd5a56cbfcd@dunslane.net>
References: <E1oxvf9-000XEs-No@gemulon.postgresql.org> <Y369jSwDb3/uzmM+@paquier.xyz> <7550ef36-4ec2-7b03-0671-0a88aab61ce7@dunslane.net> <CA+HiwqHbv4xQd-yHx0LWA04AybA+GQPy66UJxt8m32gB6zCYQQ@mail.gmail.com> <25eb9e88-2025-458c-2330-7fd5a56cbfcd@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox