pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions.
Date: Wed, 16 Aug 2017 11:56:34 -0400
Message-ID: <26168.1502898994@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+Tgmoan1cPF+rSPhX8NQ2p1pNPv+1NiqrPi-yA9ft6tyv+78A@mail.gmail.com>
References: <E1dhehy-00034e-8N@gemulon.postgresql.org>
	<23425.1502822098@sss.pgh.pa.us>
	<CA+TgmoaRuLrYSonO5y4-Dhiaw13yTukKWyJuRuCy2XHEAQ5O8A@mail.gmail.com>
	<31094.1502827694@sss.pgh.pa.us>
	<29231.1502831727@sss.pgh.pa.us>
	<CA+Tgmoa+h--4STWwP-+XkrSwcU8wWtNCV7ODcQZgyy=Xi+Np6g@mail.gmail.com>
	<7013.1502836842@sss.pgh.pa.us>
	<CA+TgmoYB4EfN4FkpWf3UFRgMgrA2Go7FgFmu-p7Yzh+WDx9E5A@mail.gmail.com>
	<23848.1502895834@sss.pgh.pa.us>
	<CA+Tgmoan1cPF+rSPhX8NQ2p1pNPv+1NiqrPi-yA9ft6tyv+78A@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Robert Haas <robertmhaas@gmail.com> writes:
> On Wed, Aug 16, 2017 at 11:03 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Well, it has subplans, so formally I think it's restricted not unsafe
>> --- but the parallel_safe marking on constructed paths/plans is only
>> safe/not-safe, not a three-way.

> True, but when parallel_safe it not set, that means it's not
> parallel-safe, so either parallel-restricted or parallel-unsafe.  But
> if parallelModeOK is true, then it had better be parallel-restricted,
> not parallel-unsafe.

Ah, I see.

> So I still don't see what's wrong here, other than that the comment is
> evidently not half clear enough.

I can get on board with that statement.  Can you draft a better wording?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (16+ messages)  latest in thread

Message-ID: <26168.1502898994@sss.pgh.pa.us>
Permalink:  ../26168.1502898994@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/26168.1502898994@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: [COMMITTERS] pgsql: Simplify plpgsql's check for simple expressions.
  In-Reply-To: <26168.1502898994@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox