pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org, Robert Haas <rhaas@postgresql.org>
Subject: Re: pgsql: Unbreak the build.
Date: Wed, 23 Mar 2022 11:55:37 -0400
Message-ID: <2722835.1648050937@sss.pgh.pa.us> (raw)
In-Reply-To: <D0868780-E8A6-4CD9-A00C-60FB520094A3@anarazel.de>
References: <E1nX1uH-0011tI-8h@gemulon.postgresql.org>
	<C6A7643A-582B-47F7-A03D-01736BC0349B@anarazel.de>
	<D0868780-E8A6-4CD9-A00C-60FB520094A3@anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> And windows still fails tests after this commit: https://cirrus-ci.com/task/6424123323711488?logs=test_bin#L22

Yeah.  drongo is reporting

# Running: pg_basebackup --no-sync -cfast -D C:\\prog\\bf\\root\\HEAD\\pgsql.build\\src\\bin\\pg_basebackup\\tmp_check\\tmp_test_vv4i/tarbackup -Ft
Assertion failed: 0, file c:\\prog\\bf\\root\\HEAD\\pgsql.build\\src\\bin\\pg_basebackup\\walmethods.c, line 953
not ok 82 - tar format

#   Failed test 'tar format'
#   at t/010_pg_basebackup.pl line 261.

which is pointing at

		/* not reachable */
		Assert(false);

so it's not so unreachable after all.

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <2722835.1648050937@sss.pgh.pa.us>
Permalink:  ../2722835.1648050937@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2722835.1648050937@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, rhaas@postgresql.org
  Subject: Re: pgsql: Unbreak the build.
  In-Reply-To: <2722835.1648050937@sss.pgh.pa.us>
  References: <E1nX1uH-0011tI-8h@gemulon.postgresql.org> <C6A7643A-582B-47F7-A03D-01736BC0349B@anarazel.de> <D0868780-E8A6-4CD9-A00C-60FB520094A3@anarazel.de> <2722835.1648050937@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox