From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <tmunro@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.
Date: Tue, 11 Jan 2022 14:35:56 -0500
Message-ID: <2760528.1641929756@sss.pgh.pa.us> (raw)
In-Reply-To: <E1mvWTz-0006Hc-Dn@gemulon.postgresql.org>
References: <E1mvWTz-0006Hc-Dn@gemulon.postgresql.org>
Thomas Munro <tmunro@postgresql.org> writes:
> Check for STATUS_DELETE_PENDING on Windows.
The src/include/port/win32ntdll.h file added by this commit has
a couple of deficiencies:
1. It lacks the usual anti-multiple-inclusion guard, i.e.
#ifndef WIN32NTDLL_H
or the like. Was there a specific reason to omit that?
2. headerscheck and cpluspluscheck don't like it, at least
not on non-Windows:
$ src/tools/pginclude/headerscheck
In file included from /tmp/headerscheck.WKh8cz/test.c:2:
./src/include/port/win32ntdll.h:20:10: fatal error: ntstatus.h: No such file or directory
#include <ntstatus.h>
^~~~~~~~~~~~
One way to solve that, perhaps, is to wrap the whole header
in #ifdef WIN32. But I think our more usual practice has
been to add such headers to the exclusion lists in those
two scripts.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.
In-Reply-To: <2760528.1641929756@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox