From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Fix broken multibyte regression tests.
Date: Sat, 28 Nov 2015 13:55:09 -0500
Message-ID: <27771.1448736909@sss.pgh.pa.us> (raw)
In-Reply-To: <E1ZOG3B-0004Dz-El@gemulon.postgresql.org>
References: <E1ZOG3B-0004Dz-El@gemulon.postgresql.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
Tatsuo Ishii <ishii@postgresql.org> writes:
> Fix broken multibyte regression tests.
> commit 9043Fe390f4f0b4586cfe59cbd22314b9c3e2957 broke multibyte
> regression tests because the commit removes the warning message when
> temporary hash indexes is created, which has been added by commit
> 07af523870bcfe930134054febd3a6a114942e5b.
> Back patched to 9.5 stable tree.
AFAICT this patch was incorrect and should be reverted, because the
src/test/mb tests all fail for me, in both HEAD and 9.5, as a consequence
of getting hash-index WARNINGs that are not in the expected-files. The
commit you mention (which is 9043ef390f4f0b4586cfe59cbd22314b9c3e2957 not
what's cited in this commit message) disabled the WARNING for temporary
and unlogged hash indexes, but the indexes created by the test scripts
are neither.
Please recheck it.
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, ishii@postgresql.org
Subject: Re: pgsql: Fix broken multibyte regression tests.
In-Reply-To: <27771.1448736909@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox