pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o
Date: Sat, 07 Aug 2021 15:12:38 -0400
Message-ID: <2788096.1628363558@sss.pgh.pa.us> (raw)
In-Reply-To: <20210807185141.ncmuxchr6d2qv2v6@alap3.anarazel.de>
References: <20210807030652.qf5wsbhxk7dpsmtn@alap3.anarazel.de>
	<2640064.1628306008@sss.pgh.pa.us>
	<2640490.1628306556@sss.pgh.pa.us>
	<20210807044952.orwuf7hua2wytx4g@alap3.anarazel.de>
	<20210807051149.x2j3n64ejcu23hm4@alap3.anarazel.de>
	<2675112.1628350987@sss.pgh.pa.us>
	<20210807164850.52atvo2qkmtfnzgt@alap3.anarazel.de>
	<2771326.1628356007@sss.pgh.pa.us>
	<20210807172556.rda5m7jjhk7ktukl@alap3.anarazel.de>
	<2782786.1628357836@sss.pgh.pa.us>
	<20210807185141.ncmuxchr6d2qv2v6@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2021-08-07 13:37:16 -0400, Tom Lane wrote:
>> Depends what you want to define as a bug.  What I am not happy about
>> is the prospect of random assertion failures for the next six months
>> while you finish redesigning half of the system.  The rest of us
>> have work we want to get done, too.  I don't object to the idea of
>> making no-lost-events an end goal, but we are clearly not ready
>> for that today.

> I don't know what to do about that. How would we even find these cases if they
> aren't hit during regression tests on my machine (nor on a lot of others)?

The regression tests really aren't that helpful for testing the problem
scenario here, which basically is SIGTERM'ing a query-in-progress.
I'm rather surprised that the buildfarm managed to exercise that at all.

You might try setting up a test scaffold that runs the core regression
tests and SIGINT's the postmaster, or alternatively SIGTERM's some
individual session, at random times partway through.  Obviously this
will make the regression tests report failure, but what to look for
is if anything dumps core on the way out.

			regards, tom lane





view thread (53+ messages)  latest in thread

Message-ID: <2788096.1628363558@sss.pgh.pa.us>
Permalink:  ../2788096.1628363558@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2788096.1628363558@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o
  In-Reply-To: <2788096.1628363558@sss.pgh.pa.us>
  References: <20210807030652.qf5wsbhxk7dpsmtn@alap3.anarazel.de> <2640064.1628306008@sss.pgh.pa.us> <2640490.1628306556@sss.pgh.pa.us> <20210807044952.orwuf7hua2wytx4g@alap3.anarazel.de> <20210807051149.x2j3n64ejcu23hm4@alap3.anarazel.de> <2675112.1628350987@sss.pgh.pa.us> <20210807164850.52atvo2qkmtfnzgt@alap3.anarazel.de> <2771326.1628356007@sss.pgh.pa.us> <20210807172556.rda5m7jjhk7ktukl@alap3.anarazel.de> <2782786.1628357836@sss.pgh.pa.us> <20210807185141.ncmuxchr6d2qv2v6@alap3.anarazel.de> <2788096.1628363558@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox