pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te
Date: Thu, 06 Apr 2023 18:04:01 -0400
Message-ID: <2810776.1680818641@sss.pgh.pa.us> (raw)
In-Reply-To: <2800993.1680817652@sss.pgh.pa.us>
References: <E1pkVfC-001jBy-2n@gemulon.postgresql.org>
	<20230406213813.uep7plg6lvcywujo@awork3.anarazel.de>
	<2800993.1680817652@sss.pgh.pa.us>

I wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2023-04-06 19:52:55 +0000, Tom Lane wrote:
>>> Fix ts_headline() edge cases for empty query and empty search text.

>> Unfortunately there appears to be some portability issue with this. Causes a
>> test output difference on macos.

> Huh ... looking.

It's not about macOS, it's about that build script using
-DRANDOMIZE_ALLOCATED_MEMORY, which causes coerce_type() to
call tsqueryin() twice.  So you get the bleat twice.  Ugh.

I can work around it in these test cases by using to_tsquery()
instead of just "''::tsquery", but maybe we should rethink
something.

			regards, tom lane





view thread (9+ messages)

Message-ID: <2810776.1680818641@sss.pgh.pa.us>
Permalink:  ../2810776.1680818641@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/2810776.1680818641@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te
  In-Reply-To: <2810776.1680818641@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox