From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te
Date: Thu, 6 Apr 2023 14:38:13 -0700
Message-ID: <20230406213813.uep7plg6lvcywujo@awork3.anarazel.de> (raw)
In-Reply-To: <E1pkVfC-001jBy-2n@gemulon.postgresql.org>
References: <E1pkVfC-001jBy-2n@gemulon.postgresql.org>
Hi,
On 2023-04-06 19:52:55 +0000, Tom Lane wrote:
> Fix ts_headline() edge cases for empty query and empty search text.
Unfortunately there appears to be some portability issue with this. Causes a
test output difference on macos. Noticed it when testing something I was about
to push, and I was very confused for a second how my change could have a
portability aspect :)
https://cirrus-ci.com/build/6629557554380800https://api.cirrus-ci.com/v1/artifact/task/4764833480966144/testrun/build/testrun/regress/regress/re...inline patch 1: /Users/admin/pgsql/build/testrun/regress/regress/results/tsearch.out (+3/-0 lines) download inline-1.patchdiff -U3 /Users/admin/pgsql/src/test/regress/expected/tsearch.out /Users/admin/pgsql/build/testrun/regress/regress/results/tsearch.out
--- /Users/admin/pgsql/src/test/regress/expected/tsearch.out 2023-04-06 20:03:11+++ /Users/admin/pgsql/build/testrun/regress/regress/results/tsearch.out 2023-04-06 20:05:56@@ -2133,6 +2133,9 @@
NOTICE: text-search query doesn't contain lexemes: ""
LINE 2: '', ''::tsquery);
^
+NOTICE: text-search query doesn't contain lexemes: ""+LINE 2: '', ''::tsquery);+ ^
ts_headline
-------------
Sure looks like somehow there's duplicate NOTICEs?
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix ts_headline() edge cases for empty query and empty search te
In-Reply-To: <20230406213813.uep7plg6lvcywujo@awork3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox