From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move gramparse.h to src/backend/parser
Date: Wed, 14 Sep 2022 15:37:06 -0400
Message-ID: <2862807.1663184226@sss.pgh.pa.us> (raw)
In-Reply-To: <E1oYJbR-000FbR-LP@gemulon.postgresql.org>
References: <E1oYJbR-000FbR-LP@gemulon.postgresql.org>
John Naylor <john.naylor@postgresql.org> writes:
> Move gramparse.h to src/backend/parser
The cfbot is unhappy since this commit; some but not all tests fail with
[09:33:13.793] In file included from scan.c:39:
[09:33:13.793] ./gramparse.h:29:10: fatal error: 'gram.h' file not found
[09:33:13.794] #include "gram.h"
[09:33:13.794] ^~~~~~~~
[09:33:13.839] In file included from parser.c:25:
[09:33:13.839] ./gramparse.h:29:10: fatal error: 'gram.h' file not found
[09:33:13.839] #include "gram.h"
[09:33:13.839] ^~~~~~~~
What I think is happening is that it was a mistake to remove
parser/gram.h from the dependencies of backend/Makefile's
generated-headers target: that allows builds to proceed before
gram.h has necessarily been created. The fact that it works
at all for anybody says that there's another dependency path
somewhere that causes bison to get run ... but, seemingly,
that doesn't always happen soon enough in a parallel build.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, john.naylor@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Move gramparse.h to src/backend/parser
In-Reply-To: <2862807.1663184226@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox