pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add libpq parameter 'channel_binding'.
Date: Mon, 30 Sep 2019 17:41:46 -0400
Message-ID: <28779.1569879706@sss.pgh.pa.us> (raw)
In-Reply-To: <55c81610cba6bcc5289268ae46c686cabc439a0f.camel@j-davis.com>
References: <E1iCVWg-00057D-8U@gemulon.postgresql.org>
	<24857.1569775891@sss.pgh.pa.us>
	<20190929234733.GA2888@paquier.xyz>
	<20190930064539.GK2888@paquier.xyz>
	<20190930070826.GM2888@paquier.xyz>
	<55c81610cba6bcc5289268ae46c686cabc439a0f.camel@j-davis.com>

Jeff Davis <pgsql@j-davis.com> writes:
> Looks good to me, though I think you need to update the expected error
> message in the test you just added.

The test case did pass for me when I tried it on an old-openssl machine
a few hours ago.  I don't think this test has any way to exercise the
code path where the server has support and the client doesn't (or
vice versa).

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <28779.1569879706@sss.pgh.pa.us>
Permalink:  ../28779.1569879706@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/28779.1569879706@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Add libpq parameter 'channel_binding'.
  In-Reply-To: <28779.1569879706@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox