agora inbox for pgsql-committers@postgresql.org
help / color / mirror / Atom feedFrom: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20
Date: Wed, 19 Oct 2016 23:22:13 -0400
Message-ID: <29391.1476933733@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEepm=2kL=uhxPAEYtaSD4F_jojwz8JDtUt-hRqhq71G2FTUoQ@mail.gmail.com>
References: <E1bwzmk-0002YY-Vd@gemulon.postgresql.org>
<CAEepm=2kL=uhxPAEYtaSD4F_jojwz8JDtUt-hRqhq71G2FTUoQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> On Thu, Oct 20, 2016 at 11:56 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Sync our copy of the timezone library with IANA release tzcode2016g.
> My compiler (Apple LLVM version 8.0.0 (clang-800.0.38)) doesn't like this:
> zic.c:427:53: error: implicit conversion from 'unsigned long long' to
> 'int' changes value from 18446744073709551615 to -1
> [-Werror,-Wconstant-conversion]
> int amax = nitems_max < SIZE_MAX ? nitems_max : SIZE_MAX;
> ~~~~ ^~~~~~~~
Hmm ... I wonder what the IANA guys think they're doing here?
There are no platforms on which INT_MAX is more than SIZE_MAX.
I think we can just take this out.
(My RHEL6 compiler didn't object to this, but I can reproduce
it on Mac.)
regards, tom lane
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
view thread (104+ messages) latest in thread
Message-ID: <29391.1476933733@sss.pgh.pa.us>
Permalink: ../29391.1476933733@sss.pgh.pa.us/
Also on: postgresql.org/message-id/29391.1476933733@sss.pgh.pa.us
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com
Subject: Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20
In-Reply-To: <29391.1476933733@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox