pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Andrew Dunstan <andrew@dunslane.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass
Date: Mon, 3 Jul 2023 12:54:08 +0200
Message-ID: <30209687-c5f6-e659-67b7-a4972701c601@enterprisedb.com> (raw)
In-Reply-To: <74782c07-7e23-9f3b-a247-f468667b3dc0@dunslane.net>
References: <E1qFsOk-001UnC-GG@gemulon.postgresql.org>
	<ZKIU4mhWpgJOM0W0@paquier.xyz>
	<229983.1688344210@sss.pgh.pa.us>
	<74782c07-7e23-9f3b-a247-f468667b3dc0@dunslane.net>

On 7/3/23 04:18, Andrew Dunstan wrote:
> 
> On 2023-07-02 Su 20:30, Tom Lane wrote:
>> Michael Paquier <michael@paquier.xyz> writes:
>>> koel has failed its indent step after these commits.  I am unsure
>>> whether you need to fix this as it does not seem that we have a
>>> consensus to automate that, just FYI.
>> Well, *somebody* has to fix it, otherwise why did we set up the animal?
>> But the impression I had was that a majority of committers want to
>> start keeping the tree pgindent-clean.
>>
>> 			
> 
> 
> I think we need to spell out expectations more clearly. Here's what I
> said to Tomas in a private message:
> 
>     I think the expectation is that, while there might be cases where
>     you want to make some commits and then indent afterwards, so the
>     changes are clear, for most cases you should try to commit
>     pre-indented patches.
> 
> But that's just my opinion. I think we need to spell it out more formally.
> 

I've pushed a fix for the indentation issues caused by my commits (this
one and the commit touching trigger.c). But I agree with Andrew it'd be
good to spell out the expectations - perhaps it's spelled out somewhere
deep in the pgindent, not sure.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (5+ messages)

Message-ID: <30209687-c5f6-e659-67b7-a4972701c601@enterprisedb.com>
Permalink:  ../30209687-c5f6-e659-67b7-a4972701c601@enterprisedb.com/
Also on:    postgresql.org/message-id/30209687-c5f6-e659-67b7-a4972701c601@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, andrew@dunslane.net, tgl@sss.pgh.pa.us, michael@paquier.xyz, tomas.vondra@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Introduce bloom_filter_size for BRIN bloom opclass
  In-Reply-To: <30209687-c5f6-e659-67b7-a4972701c601@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox