pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Implement jsonpath .datetime() method
Date: Wed, 25 Sep 2019 19:12:29 -0400
Message-ID: <30277.1569453149@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfdteFKW6MLpXM4md99m55YAuXs0n9_P2wiTq_EmG09doUA@mail.gmail.com>
References: <E1iDDKf-0008VX-RT@gemulon.postgresql.org>
	<CAPpHfdteFKW6MLpXM4md99m55YAuXs0n9_P2wiTq_EmG09doUA@mail.gmail.com>

Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> I've noticed buildfarm is unhappy with my commits.

The proximate problem seems to be that compareItems() is insufficiently
careful to ensure that both values are non-null before passing them
off to datatype-specific code.  The code accidentally fails to crash
on 64-bit machines, but it's still giving garbage answers, I think.

			regards, tom lane





view thread (16+ messages)  latest in thread

Message-ID: <30277.1569453149@sss.pgh.pa.us>
Permalink:  ../30277.1569453149@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/30277.1569453149@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, a.korotkov@postgrespro.ru, akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Implement jsonpath .datetime() method
  In-Reply-To: <30277.1569453149@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox