From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.
Date: Wed, 17 May 2017 10:14:29 -0400
Message-ID: <30659.1495030469@sss.pgh.pa.us> (raw)
In-Reply-To: <20170517140847.lasiafwmsxgzppm6@alvherre.pgsql>
References: <20170517140847.lasiafwmsxgzppm6@alvherre.pgsql>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> There are some changes here that should be reverted; for instance:
> - printf(_(" -c, --checkpoint=fast|spread\n"
> - " set fast or spread checkpointing\n"));
> + printf(_(" -c, --checkpoint=fast|spread\n"));
> + printf(_(" set fast or spread checkpointing\n"));
> From the translator's point of view the patched version doesn't make
> sense because they are two separate strings. In the original, it's a
> single translatable string. Particularly in pg_waldump's -p, where a
> phrase is now cut in the middle.
What I was concerned about was that pgindent will reindent the second
line so that it's impossible to tell whether the spacing is correct.
That might not matter to translators but it will be a problem for
source-level maintenance.
Maybe we should rethink the whole idea of breaking these entries across
lines, and just accept that the commentary doesn't line up with other
lines:
printf(_(" -c, --checkpoint=fast|spread set fast or spread checkpointing\n"));
Thoughts?
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, pgsql-hackers@postgresql.org
Subject: Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.
In-Reply-To: <30659.1495030469@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox