pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reduce running time of jsonb_sqljson test
Date: Wed, 06 Apr 2022 11:20:02 -0400
Message-ID: <3084516.1649258402@sss.pgh.pa.us> (raw)
In-Reply-To: <E1nc6gG-000aiW-HK@gemulon.postgresql.org>
References: <E1nc6gG-000aiW-HK@gemulon.postgresql.org>

Andrew Dunstan <andrew@dunslane.net> writes:
> The test created a 1m row table in order to test parallel operation of
> JSON_VALUE.

Egad.

> However, this was more than were needed for the test, so
> save time by halving it, and also by making the table unlogged.

This seems like a rather inappropriate fix.  I would say that a test
of this size does not belong in the core regression tests AT ALL.

			regards, tom lane





view thread (2+ messages)

Message-ID: <3084516.1649258402@sss.pgh.pa.us>
Permalink:  ../3084516.1649258402@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3084516.1649258402@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net
  Subject: Re: pgsql: Reduce running time of jsonb_sqljson test
  In-Reply-To: <3084516.1649258402@sss.pgh.pa.us>
  References: <E1nc6gG-000aiW-HK@gemulon.postgresql.org> <3084516.1649258402@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox