pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Thomas Munro <tmunro@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove --disable-spinlocks.
Date: Tue, 30 Jul 2024 14:09:42 +0300
Message-ID: <310f4005-91d7-42b2-ac70-92624260dd28@iki.fi> (raw)
In-Reply-To: <E1sYkdl-001sbn-GZ@gemulon.postgresql.org>
References: <E1sYkdl-001sbn-GZ@gemulon.postgresql.org>

On 30/07/2024 14:03, Thomas Munro wrote:
> Remove --disable-spinlocks.

Sorry, spotted this only now:

> --- a/src/backend/postmaster/launch_backend.c
> +++ b/src/backend/postmaster/launch_backend.c
> @@ -108,9 +108,7 @@ typedef struct
>  #ifdef USE_INJECTION_POINTS
>     struct InjectionPointsCtl *ActiveInjectionPoints;
>  #endif
> -#ifndef HAVE_SPINLOCKS
>     PGSemaphore *SpinlockSemaArray;
> -#endif
>     int         NamedLWLockTrancheRequests;
>     NamedLWLockTranche *NamedLWLockTrancheArray;
>     LWLockPadded *MainLWLockArray;

The SpinLockSemaArray field should be completely completely, nut just 
the #ifndef guard around it.

-- 
Heikki Linnakangas
Neon (https://neon.tech)

view thread (3+ messages)  latest in thread

Message-ID: <310f4005-91d7-42b2-ac70-92624260dd28@iki.fi>
Permalink:  ../310f4005-91d7-42b2-ac70-92624260dd28@iki.fi/
Also on:    postgresql.org/message-id/310f4005-91d7-42b2-ac70-92624260dd28@iki.fi

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: hlinnaka@iki.fi, tmunro@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Remove --disable-spinlocks.
  In-Reply-To: <310f4005-91d7-42b2-ac70-92624260dd28@iki.fi>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox