From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Use the terminology "WAL file" not "log file" more consistently.
Date: Thu, 15 Sep 2022 00:48:22 -0400
Message-ID: <3122568.1663217302@sss.pgh.pa.us> (raw)
In-Reply-To: <CALj2ACVKH2v5s_qFDd9YxPhmRKL+OC4ukUdWaD3t1MWV5W7ZLA@mail.gmail.com>
References: <E1oYb46-000N30-F2@gemulon.postgresql.org>
<fbea8c6f-415a-bad9-c3de-969c40d08a84@dunslane.net>
<3043210.1663205920@sss.pgh.pa.us>
<CALj2ACVKH2v5s_qFDd9YxPhmRKL+OC4ukUdWaD3t1MWV5W7ZLA@mail.gmail.com>
Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> writes:
> We seem to be maintaining old code in pg_upgrade to not break it, see
> [3]. I can think of a fix [4] or just [5], it may not be great to do
> these kinds of fixes for all the pg_resetwal output changes. Since the
> changes we make to the output formats of controlfile or pg_resetwal
> are very rare, any of [4] or [5] looks good to me and it is better
> than backporting [2] IMO.
Yeah, the lowest-tech solution is to accept either spelling of
the description string. But I'm not very happy with the whole
approach right now. We should have an implementation that isn't
dependent on how user-friendly strings are spelled. (git seems
a bit ahead of us here, with its distinction between "plumbing"
and "porcelain" operations.)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, bharath.rupireddyforpostgres@gmail.com, andrew@dunslane.net
Subject: Re: pgsql: Use the terminology "WAL file" not "log file" more consistently.
In-Reply-To: <3122568.1663217302@sss.pgh.pa.us>
References: <E1oYb46-000N30-F2@gemulon.postgresql.org> <fbea8c6f-415a-bad9-c3de-969c40d08a84@dunslane.net> <3043210.1663205920@sss.pgh.pa.us> <CALj2ACVKH2v5s_qFDd9YxPhmRKL+OC4ukUdWaD3t1MWV5W7ZLA@mail.gmail.com> <3122568.1663217302@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox