pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Cc: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Implement jsonpath .datetime() method
Date: Sat, 12 Oct 2019 22:24:27 -0400
Message-ID: <31235.1570933467@sss.pgh.pa.us> (raw)
In-Reply-To: <CAPpHfdvRPRh_mTGar5WmDeRZ=U5dOXHdxspYYD=76m3knNGjXA@mail.gmail.com>
References: <a5629d0c-8162-7559-16aa-0c8390d6ba5f@postgrespro.ru>
	<CAPpHfdtOS270Jf7qNZwVg-aAMLgW5PJmfXS5FsB48ekxvHp3Sw@mail.gmail.com>
	<CA+Tgmoad=8vPjr1krdiE5qbaRoJPCaBkq8jQm+o4dhUYZHC7Nw@mail.gmail.com>
	<CAPpHfdvbxyk2_ODMomMWKaUg1EZdJbo3OrK2A-WqSoSwvvm4Wg@mail.gmail.com>
	<CA+TgmoaTdXT8wwmmnM3sBBG2FZQbb5DpXQBoJ+HSvsy6abQQeA@mail.gmail.com>
	<CAPpHfdvRPRh_mTGar5WmDeRZ=U5dOXHdxspYYD=76m3knNGjXA@mail.gmail.com>

Alexander Korotkov <a.korotkov@postgrespro.ru> writes:
> This patch also changes the way timestamp to timestamptz cast works.
> Previously it did timestamp2tm() then tm2timestamp().  Instead, after
> timestamp2tm() it calculates timezone offset and applies it to
> original timestamp value.  I hope this is correct.

I'd wonder whether this gives the same answers near DST transitions,
where it's not real clear which offset applies.

Please *don't* wrap this sort of thing into an unrelated feature patch.

			regards, tom lane





view thread (16+ messages)  latest in thread

Message-ID: <31235.1570933467@sss.pgh.pa.us>
Permalink:  ../31235.1570933467@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/31235.1570933467@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, a.korotkov@postgrespro.ru, robertmhaas@gmail.com, n.gluhov@postgrespro.ru, pgsql-committers@lists.postgresql.org, akorotkov@postgresql.org, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Implement jsonpath .datetime() method
  In-Reply-To: <31235.1570933467@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox