From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <akorotkov@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix page modification outside of critical section in GIN
Date: Sun, 09 Feb 2020 12:05:32 -0500
Message-ID: <31240.1581267932@sss.pgh.pa.us> (raw)
In-Reply-To: <21620.1581098806@sss.pgh.pa.us>
References: <E1iXAuR-0001k9-Cn@gemulon.postgresql.org>
<21620.1581098806@sss.pgh.pa.us>
I wrote:
> Alexander Korotkov <akorotkov@postgresql.org> writes:
>> Fix page modification outside of critical section in GIN
> I happened to notice, while reviewing stuff for the release notes,
> that this patch does not do what the commit message says. The
> previous code modified the pd_prune_xid of the "dBuffer" page,
> but now it's modifying the pd_prune_xid of the "lBuffer" page.
> Is that actually correct?
Since we're rapidly approaching the wrap deadline for this week's
releases, I took it upon myself to review this code more carefully,
and concluded that indeed it isn't correct. I pushed a fix that
moves the GinPageSetDeleteXid call again.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, akorotkov@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix page modification outside of critical section in GIN
In-Reply-To: <31240.1581267932@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox