From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties.
Date: Thu, 26 Jan 2023 21:08:23 -0500
Message-ID: <3248936.1674785303@sss.pgh.pa.us> (raw)
In-Reply-To: <Y9MZxVrCoutVbMCM@paquier.xyz>
References: <E1pKLii-005G5B-Br@gemulon.postgresql.org>
<20230126114659.x3yuypot7p6zj73c@alvherre.pgsql>
<CA+TgmoYyJrOkBtFpSpVaZML-EPnG9VwSpvicj8=5Sbu647KRcQ@mail.gmail.com>
<25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net>
<20230126183106.GS22427@telsasoft.com>
<Y9MZxVrCoutVbMCM@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jan 26, 2023 at 12:31:06PM -0600, Justin Pryzby wrote:
>> On Thu, Jan 26, 2023 at 09:46:07AM -0500, Andrew Dunstan wrote:
>>> Would it be worth adding a check right at the end of the schedule that
>>> makes sure there are no such roles left?
>> Yes, because the alternative is to have cirrus run "installcheck"
>> twice..
> Agreed about doing something like that, with a new SQL script perhaps?
> We can rely on -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS here, and
> I'd like to think that nobody creates such role names or they would
> see failures with the new query.
Yeah ... if we put it into an existing script, somebody will blindly
add more tests after it someday. I suggest calling it "test_cleanup"
to pair with "test_setup".
Is it worth checking for leftover regress_xxx tablespaces as well as
roles?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pryzby@telsasoft.com, andrew@dunslane.net, robertmhaas@gmail.com, alvherre@alvh.no-ip.org
Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties.
In-Reply-To: <3248936.1674785303@sss.pgh.pa.us>
References: <E1pKLii-005G5B-Br@gemulon.postgresql.org> <20230126114659.x3yuypot7p6zj73c@alvherre.pgsql> <CA+TgmoYyJrOkBtFpSpVaZML-EPnG9VwSpvicj8=5Sbu647KRcQ@mail.gmail.com> <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> <20230126183106.GS22427@telsasoft.com> <Y9MZxVrCoutVbMCM@paquier.xyz> <3248936.1674785303@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox