pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Daniel Gustafsson <dgustafsson@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Skip \password TAP test on old IPC::Run versions
Date: Sat, 08 Apr 2023 12:23:49 -0400
Message-ID: <3588535.1680971029@sss.pgh.pa.us> (raw)
In-Reply-To: <6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net>
References: <E1pl943-0023OF-Ol@gemulon.postgresql.org>
	<6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net>

Andrew Dunstan <andrew@dunslane.net> writes:
> Stylistic nitpick: It's not necessary to have 2 evals here:

> +   skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless
> +       (eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= 
> '0.98' });

> just say "eval { require IO::Pty; return $IPC::Run::VERSION >= '0.98'; }"

What I was wondering about was if it's safe to depend on the VERSION
being fully numeric.  Can't we write "use IPC::Run 0.98;" and let
some other code manage the version comparison?

			regards, tom lane





view thread (8+ messages)  latest in thread

Message-ID: <3588535.1680971029@sss.pgh.pa.us>
Permalink:  ../3588535.1680971029@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3588535.1680971029@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Skip \password TAP test on old IPC::Run versions
  In-Reply-To: <3588535.1680971029@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox