pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Daniel Gustafsson <dgustafsson@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Skip \password TAP test on old IPC::Run versions
Date: Sat, 8 Apr 2023 11:46:23 -0400
Message-ID: <6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net> (raw)
In-Reply-To: <E1pl943-0023OF-Ol@gemulon.postgresql.org>
References: <E1pl943-0023OF-Ol@gemulon.postgresql.org>


On 2023-04-08 Sa 09:57, Daniel Gustafsson wrote:
> Skip \password TAP test on old IPC::Run versions
>
> IPC::Run versions prior to 0.98 cause the interactive session to time out,
> so SKIP the test in case these versions are detected (they are within the
> base requirement for our TAP tests in general).  Error reported by the BF
> and investigation by Tom Lane.
>
> Discussion:https://postgr.es/m/414A86BD-986B-48A7-A1E4-EEBCE5AF08CB@yesql.se


Stylistic nitpick: It's not necessary to have 2 evals here:


+   skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless
+       (eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= 
'0.98' });


just say "eval { require IO::Pty; return $IPC::Run::VERSION >= '0.98'; }"


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (8+ messages)  latest in thread

Message-ID: <6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net>
Permalink:  ../6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net/
Also on:    postgresql.org/message-id/6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, dgustafsson@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Skip \password TAP test on old IPC::Run versions
  In-Reply-To: <6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox