From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Robert Haas <rhaas@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow db.schema.table patterns, but complain about random garbag
Date: Fri, 22 Apr 2022 10:04:05 -0400
Message-ID: <3687648.1650636245@sss.pgh.pa.us> (raw)
In-Reply-To: <3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net>
References: <E1nhCcm-000HvW-AT@gemulon.postgresql.org>
<3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net>
Andrew Dunstan <andrew@dunslane.net> writes:
> This has upset the buildfarm's msys2 animals. There appears to be some
> wildcard expansion going on that causes the problem. I don't know why it
> should here when it's not causing trouble elsewhere. I have tried
> changing the way the tests are quoted, without success. Likewise,
> setting SHELLOPTS=noglob didn't work.
> At this stage I'm fresh out of ideas to fix it. It's also quite possible
> that my diagnosis is wrong.
When I was looking at this patch, I thought the number of test cases
was very substantially out of line anyway. I suggest that rather
than investing a bunch of brain cells trying to work around this,
we just remove the failing test cases.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, rhaas@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow db.schema.table patterns, but complain about random garbag
In-Reply-To: <3687648.1650636245@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox