pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Daniel Gustafsson <daniel@yesql.se>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor the sslfiles Makefile target for ease of use
Date: Wed, 27 Oct 2021 21:57:42 +0200
Message-ID: <387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se> (raw)
In-Reply-To: <7614BC3D-0B3B-4D9C-8801-D771042EF2B4@yesql.se>
References: <E1mctg6-0002lC-7l@gemulon.postgresql.org>
	<20211026174152.jjcagswnbhxu7uqz@alap3.anarazel.de>
	<7614BC3D-0B3B-4D9C-8801-D771042EF2B4@yesql.se>

> On 27 Oct 2021, at 16:37, Daniel Gustafsson <daniel@yesql.se> wrote:
> 
>> On 26 Oct 2021, at 19:41, Andres Freund <andres@anarazel.de> wrote:
> 
>> This fails during 'make clean' in a vpath build, because sslfiles.mk cannot be
>> found. Probably just needs
> 
> It does in fact need that diff, but sslfiles.mk also needs to be taught about
> the current $(srcdir) to properly function under VPATH for "make sslfiles".

Discussing this off-list with Jacob, and dabbling some more with it, this needs
more thought.  It's not clear what make sslfiles should do in a VPATH build,
and where, since the artefacts are both generated and distributed.  I've pushed
the small fix to ensure "make clean" works as that's a much more common
usecase, to allow for time to discuss "make sslfiles" on -hackers.

--
Daniel Gustafsson		https://vmware.com/






view thread (9+ messages)  latest in thread

Message-ID: <387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se>
Permalink:  ../387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se/
Also on:    postgresql.org/message-id/387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: daniel@yesql.se, andres@anarazel.de
  Subject: Re: pgsql: Refactor the sslfiles Makefile target for ease of use
  In-Reply-To: <387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se>
  References: <E1mctg6-0002lC-7l@gemulon.postgresql.org> <20211026174152.jjcagswnbhxu7uqz@alap3.anarazel.de> <7614BC3D-0B3B-4D9C-8801-D771042EF2B4@yesql.se> <387192BC-26E5-4D9A-A2C1-3F9AB79B7FC2@yesql.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox