From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Cache by-reference missing values in a long lived context
Date: Thu, 24 Aug 2023 11:27:01 -0400
Message-ID: <3907902.1692890821@sss.pgh.pa.us> (raw)
In-Reply-To: <E1qYvJA-000XT3-QX@gemulon.postgresql.org>
References: <E1qYvJA-000XT3-QX@gemulon.postgresql.org>
Andrew Dunstan <andrew@dunslane.net> writes:
> Cache by-reference missing values in a long lived context
The v11 version of this patch is causing a compiler warning for me:
In file included from heaptuple.c:58:
heaptuple.c: In function 'missing_hash':
heaptuple.c:97:3: warning: implicit declaration of function 'hash_any'; did you mean 'hash_stats'? [-Wimplicit-function-declaration]
hash_any((const unsigned char *) entry->value, entry->len));
^~~~~~~~
../../../../src/include/postgres.h:471:38: note: in definition of macro 'DatumGetUInt32'
#define DatumGetUInt32(X) ((uint32) (X))
^
It seems to work anyway, but please fix.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Cache by-reference missing values in a long lived context
In-Reply-To: <3907902.1692890821@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox