From: Heikki Linnakangas <hlinnaka@iki.fi>
To: Robert Haas <robertmhaas@gmail.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Dave Page <dpage@postgresql.org>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
Subject: Re: Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv
Date: Fri, 24 Mar 2017 12:44:24 +0200
Message-ID: <3b6c4613-798b-72aa-3f7e-319f783324f7@iki.fi> (raw)
In-Reply-To: <CA+TgmoYjNydadKTDtSZQViKM+L38uNSbKgauRKotsBNhJc43Hw@mail.gmail.com>
References: <ca12b39d-e3da-a270-86c1-43c1d6c9ad5a@iki.fi>
<20170322141305.bgxctu22pqnirtgu@alvherre.pgsql>
<CA+TgmoYjNydadKTDtSZQViKM+L38uNSbKgauRKotsBNhJc43Hw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 03/22/2017 07:44 PM, Robert Haas wrote:
> On Wed, Mar 22, 2017 at 10:13 AM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
>> Heikki Linnakangas wrote:
>>> I did some archeology, and found CheckTokenMembership() in MinGW's w32api
>>> packages version 3.14
>>> (https://sourceforge.net/projects/mingw/files/MinGW/Base/w32api/w32api-3.14/,
>>> in include/winbase.h). According to the timestamps on that download page,
>>> that was released in 2009. That was the oldest version I could find, so it
>>> might go even further back.
>>>
>>> Dave, do you know exactly what version of MinGW narwhal is running? And how
>>> difficult is it to upgrade to something slightly more modern? Ease of
>>> upgrade is another good data point on how far we need to support old
>>> versions.
>>
>> Given that this was backpatched and that it broke narwhal in all
>> branches, I think the solution needs to make narwhal work again without
>> requiring it to upgrade; so we should acquire CheckTokenMembership via
>> dynloading just like we do the other functions. If we want to require a
>> newer mingw version in pg10, that's acceptable, but it should be a
>> separate patch.
>
> +1 for not moving the minimum system requirements in the back-branches.
Ok. I reverted this patch in the back-branches, and applied the much
less invasive "V2" patch [1] instead. HEAD is unchanged, so narwhal
still fails there.
Dave: the consensus is that we no longer support the old version of
MinGW that narwhal is using, for PostgreSQL v 10. Can you modify the
configuration of narwhal to not try building 'master' anymore, or
upgrade the toolchain, please?
[1]
https://www.postgresql.org/message-id/CAB7nPqSvfu%3DKpJ%3DNX%2BYAHmgAmQdzA7N5h31BjzXeMgczhGCC%2BQ%40...
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: hlinnaka@iki.fi, robertmhaas@gmail.com, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, dpage@postgresql.org, pgsql-hackers@postgresql.org, tsunakawa.takay@jp.fujitsu.com
Subject: Re: Re: [COMMITTERS] pgsql: Fix and simplify check for whether we're running as Windows serv
In-Reply-To: <3b6c4613-798b-72aa-3f7e-319f783324f7@iki.fi>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox