pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Andrew Dunstan <andrew@dunslane.net>
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix fat fingering in 22cb6d28950
Date: Sat, 12 Apr 2025 14:33:35 -0400
Message-ID: <3fd6f7da-0453-4dde-95df-146fecfa7a92@dunslane.net> (raw)
In-Reply-To: <CAKYtNAoQaLLreOzwvad2HBJUrCgRugxpUNKnF5Obzp0HhoGH8w@mail.gmail.com>
References: <E1u310K-003f8j-2r@gemulon.postgresql.org>
	<CAKYtNAoQaLLreOzwvad2HBJUrCgRugxpUNKnF5Obzp0HhoGH8w@mail.gmail.com>


On 2025-04-11 Fr 3:24 PM, Mahendra Singh Thalor wrote:
> On Fri, 11 Apr 2025 at 04:38, Andrew Dunstan <andrew@dunslane.net> wrote:
> >
> > Fix fat fingering in 22cb6d28950
> >
> > Per Rainier Vilela
> >
> > Branch
> > ------
> > master
> >
> > Details
> > -------
> > 
> https://git.postgresql.org/pg/commitdiff/39729ec01d25dbe12e0dd8322c68f242650235c9
> >
> > Modified Files
> > --------------
> > src/bin/pg_dump/pg_restore.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
>
> Hi,
> This seems not a proper fix, rather this is adding a segfault.
>
[...]

> Here, we are passing &q, but we can't free this by destroyStringInfo(&q);
>
> *Fix*: pg_free(q.data)



Quite right. Clearly I was not having a good day on Thursday. Will fix.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

view thread (3+ messages)

Message-ID: <3fd6f7da-0453-4dde-95df-146fecfa7a92@dunslane.net>
Permalink:  ../3fd6f7da-0453-4dde-95df-146fecfa7a92@dunslane.net/
Also on:    postgresql.org/message-id/3fd6f7da-0453-4dde-95df-146fecfa7a92@dunslane.net

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, mahi6run@gmail.com, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Fix fat fingering in 22cb6d28950
  In-Reply-To: <3fd6f7da-0453-4dde-95df-146fecfa7a92@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox