public inbox for [email protected]  
help / color / mirror / Atom feed
From: Tom Lane <[email protected]>
To: Jacob Champion <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Cc: [email protected]
Cc: Andrew Dunstan <[email protected]>
Cc: Nathan Bossart <[email protected]>
Subject: Re: pgsql: libpq: Grease the protocol by default
Date: Tue, 24 Feb 2026 13:50:33 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAOYmi+=6AFrYm5LaPc=ECyLp2uh1-Y8xLA-dRBJE82JLRdiQ5g@mail.gmail.com>
References: <[email protected]>
	<CAOYmi+=4QhCjssfNEoZVK8LPtWxnfkwT5p-PAeoxtG9gpNjqOQ@mail.gmail.com>
	<[email protected]>
	<CAOYmi+k8ENYkErqSEYEqW39YWPfe_ii7g5Acm1c9asNuRMriNg@mail.gmail.com>
	<[email protected]>
	<CAOYmi+mtFBsB2zePSvbpa-2Zb-+V5bov_t2BzkGH7vfKX0ny_w@mail.gmail.com>
	<[email protected]>
	<CAOYmi+kC3AN0QJKT0OunHCmi4UU7-15eu7w-DY5ckOgHiQE1QA@mail.gmail.com>
	<[email protected]>
	<CAOYmi+=96EGcQnY2w99yLeARHsbvgT_2Bv1hjXKUziykMzMhtA@mail.gmail.com>
	<CAOYmi+=6AFrYm5LaPc=ECyLp2uh1-Y8xLA-dRBJE82JLRdiQ5g@mail.gmail.com>

Jacob Champion <[email protected]> writes:
> So pg_upgrade will use max_protocol_version=3.0 with all servers v10
> and below, in practice. There's nothing wrong with that behavior, but
> I think I should switch to a simple `< 1100` check in the code to
> avoid misleading people, unless anyone has a better way that won't
> significantly increase the cost of the backport.

Simple is good here.  I don't think we'd buy much by distinguishing
minor versions of already-EOL servers.  Also, I suspect that
pg_upgrade can't get the minor version except by starting the server
and asking it --- we don't record anything but major version on-disk.

			regards, tom lane





view thread (27+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: libpq: Grease the protocol by default
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox