From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: SQL-standard function body
Date: Thu, 8 Apr 2021 10:12:22 -0400
Message-ID: <42affe76-48c4-a78c-e548-83a16b806af2@dunslane.net> (raw)
In-Reply-To: <20210408015017.yb2tb324y6zt4o66@alap3.anarazel.de>
References: <E1lUEF5-00027L-N4@gemulon.postgresql.org>
<20210407225806.majgznh4lk34hjvu@alap3.anarazel.de>
<1730972.1617836766@sss.pgh.pa.us>
<CAApHDvo4-Uqr3jPf7O0iHgy4igdGVRX8qYtkahqBws1sRnrRRw@mail.gmail.com>
<20210408015017.yb2tb324y6zt4o66@alap3.anarazel.de>
On 4/7/21 9:50 PM, Andres Freund wrote:
> Hi,
>
> On 2021-04-08 13:33:18 +1200, David Rowley wrote:
>> On Thu, 8 Apr 2021 at 11:06, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Andres Freund <andres@anarazel.de> writes:
>>>
>>>> Might be force_parallel_mode=regress related.
>>> Yeah. On my machine, it's fine without force_parallel_mode and
>>> crashes with that. Looks like query text is not getting passed
>>> to the parallel worker in some cases.
>> I wonder if it would be worth adding a regression test run of the core
>> tests during make check-world with force_parallel_mode set to regress.
>>
>> But maybe people running the tests on slow machines might not be a fan
>> of that idea.
> I've wondered about that too. Perhaps we could reuse the pg_upgrade run?
>
Honestly I'd prefer it if we could get rid of the rerun of 'make check'
by pg_upgrade's test.sh and instead upgrade the data directory made by
the earlier 'make check' run if it's still there (which would mean we'd
need to stop it being deleted).
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, andres@anarazel.de, dgrowleyml@gmail.com, tgl@sss.pgh.pa.us, peter@eisentraut.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: SQL-standard function body
In-Reply-To: <42affe76-48c4-a78c-e548-83a16b806af2@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox