From: Andrew Dunstan <andrew@dunslane.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings
Date: Sun, 15 Sep 2024 18:07:21 -0400
Message-ID: <42f2242a-422b-4aa3-8d60-d67b229c4a52@dunslane.net> (raw)
In-Reply-To: <ZudFaDhhXHg3AAlv@momjian.us>
References: <E1spqfS-001Ehn-Cx@gemulon.postgresql.org>
<66b5b1d6-3f2a-4944-91a3-7e40a565ccac@dunslane.net>
<ZudAtNRQOkveAa91@momjian.us>
<e51357f4-4ac5-4b64-b01a-15931485702f@dunslane.net>
<ZudFaDhhXHg3AAlv@momjian.us>
On 2024-09-15 Su 4:36 PM, Bruce Momjian wrote:
> On Sun, Sep 15, 2024 at 04:33:49PM -0400, Andrew Dunstan wrote:
>> I understand perfectly what the warning is about.
>>
>> But the project's perlcritic policy is expressed at src/tools/perlcheck/
>> perlcriticrc. It's basically severity 5 plus some additions and one exception.
>> We shouldn't be imposing our personal perlcritic policies on the project.
>>
>> The change isn't bad in itself, but there shouldn't be any expectation that we
>> will keep to this policy, as it's not required by project policy.
>>
>> There is a huge mass of perlcritic issues in our perl code at severity 1 (over
>> 13000 by my count). If we're going to clean them up (which I would oppose) we
>> should do it in a systematic way. It's hard to see why this one is special.
> I guess it is special only because my policy is more strict so I wanted
> my new code to match. Should I revert it?
Yes I think so.
> Is the very tiny improvement
> not worth the churn in the code?
Yeah, I don't think it is.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, bruce@momjian.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings
In-Reply-To: <42f2242a-422b-4aa3-8d60-d67b229c4a52@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox