From: Andrew Dunstan <andrew@dunslane.net>
To: Bruce Momjian <bruce@momjian.us>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings
Date: Sun, 15 Sep 2024 14:30:47 -0400
Message-ID: <66b5b1d6-3f2a-4944-91a3-7e40a565ccac@dunslane.net> (raw)
In-Reply-To: <E1spqfS-001Ehn-Cx@gemulon.postgresql.org>
References: <E1spqfS-001Ehn-Cx@gemulon.postgresql.org>
On 2024-09-15 Su 10:56 AM, Bruce Momjian wrote:
> Perl scripts: eliminate "Useless interpolation" warnings
>
> Eliminate warnings of Perl Critic from src/tools.
>
> Backpatch-through: master
I don't understand this commit. The buildfarm members crake and koel
regularly run the perl critic checks and have not complained. See for
example from before this change:
<https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=koel&dt=2024-09-15%2003%3A34%3A02&...;
The change doesn't seem to have had any discussion either. This
particular warning is surely a very low level (i.e. fairly unimportant)
one, of the type we normally ignore. If some version of perlcritic has
raised it to severity 5 then the correct action IMNSHO would be to add
an exception for it to the perlcriticrc, like we do for
ProhibitLeadingZeros. If not, then perhaps you can explain how you got
the warnings.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew@dunslane.net, bruce@momjian.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Perl scripts: eliminate "Useless interpolation" warnings
In-Reply-To: <66b5b1d6-3f2a-4944-91a3-7e40a565ccac@dunslane.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox