From: Jeff Davis <pgsql@j-davis.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Use ICU by default at initdb time.
Date: Fri, 10 Mar 2023 10:58:49 -0800
Message-ID: <437cb29641d176ccfb9d631351582fdd96842d8d.camel@j-davis.com> (raw)
In-Reply-To: <238f8443506cce214979caa0fc3b06c5dbf99bc7.camel@j-davis.com>
References: <E1paLfy-002jGI-D8@gemulon.postgresql.org>
<d191d5841347301a8f1238f609471ddd957fc47e.camel@j-davis.com>
<dab5ce1a-0f1d-38cd-1cb4-f2b0b2d229e0@enterprisedb.com>
<dbda1a9137aeab0f441104f212696b1c2d50d5f1.camel@j-davis.com>
<ebe9a63f-d4c6-7553-1e58-7dd80a11c1c1@enterprisedb.com>
<238f8443506cce214979caa0fc3b06c5dbf99bc7.camel@j-davis.com>
On Fri, 2023-03-10 at 07:48 -0800, Jeff Davis wrote:
> On Fri, 2023-03-10 at 15:48 +0100, Peter Eisentraut wrote:
> > Yes, of course. So we can't really do what I was thinking of.
>
> OK, I plan to commit something like the patch in this thread soon. I
> just need to add an explanatory comment.
Committed a slightly narrower fix that derives the default encoding the
same way for both libc and ICU; except that ICU still uses UTF-8 for
C/POSIX/--no-locale (because ICU doesn't work with SQL_ASCII).
That seemed more consistent with the comments around
pg_get_encoding_from_locale() and it was also easier to document the -E
switch in initdb.
I'll keep an eye on the buildfarm to see if this fixes the problem or
causes other issues. But it seems like the right change.
Regards,
Jeff Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: pgsql@j-davis.com, peter.eisentraut@enterprisedb.com, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Use ICU by default at initdb time.
In-Reply-To: <437cb29641d176ccfb9d631351582fdd96842d8d.camel@j-davis.com>
References: <E1paLfy-002jGI-D8@gemulon.postgresql.org> <d191d5841347301a8f1238f609471ddd957fc47e.camel@j-davis.com> <dab5ce1a-0f1d-38cd-1cb4-f2b0b2d229e0@enterprisedb.com> <dbda1a9137aeab0f441104f212696b1c2d50d5f1.camel@j-davis.com> <ebe9a63f-d4c6-7553-1e58-7dd80a11c1c1@enterprisedb.com> <238f8443506cce214979caa0fc3b06c5dbf99bc7.camel@j-davis.com> <437cb29641d176ccfb9d631351582fdd96842d8d.camel@j-davis.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox