pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Jeff Davis <pgsql@j-davis.com>
To: Jeff Davis <jdavis@postgresql.org>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Recalculate search_path after ALTER ROLE.
Date: Wed, 09 Aug 2023 23:08:10 -0700
Message-ID: <441542f15012666c621814327415a2cbb0960e10.camel@j-davis.com> (raw)
In-Reply-To: <d4bc331366068e9605d65bfe471687b4d32528d8.camel@j-davis.com>
References: <E1qTpps-001FmA-IW@gemulon.postgresql.org>
	<d4bc331366068e9605d65bfe471687b4d32528d8.camel@j-davis.com>

On Wed, 2023-08-09 at 16:12 -0700, Jeff Davis wrote:
> I'm not sure yet, but this looks like a possible pre-existing bug, or
> some incorrect assumption I made in fa2e874946.

Before my commit the behavior is the same. Here's a minimal repro
(debug_parallel_query set to 'on' or 'regress'):

  s1:
    CREATE USER u1;
    SET SESSION AUTHORIZATION u1;

  s2:
    ALTER ROLE u1 RENAME TO u2;

  s1:
    SELECT 1;
    ERROR:  role "u1" does not exist
    CONTEXT:  while setting parameter "session_authorization" to "u1"

Given that it works fine without parallel query, I'm inclined to call
this a parallel query bug. The error is coming from RestoreGUCState().

That being said, the buildfarm is red after my commit, so unless
someone sees a quick fix here, perhaps I should remove my isolation
test? I don't want to revert my whole commit, because it seems correct
and fixes a separate bug.

Regards,
	Jeff Davis






view thread (10+ messages)  latest in thread

Message-ID: <441542f15012666c621814327415a2cbb0960e10.camel@j-davis.com>
Permalink:  ../441542f15012666c621814327415a2cbb0960e10.camel@j-davis.com/
Also on:    postgresql.org/message-id/441542f15012666c621814327415a2cbb0960e10.camel@j-davis.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: pgsql@j-davis.com, jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Recalculate search_path after ALTER ROLE.
  In-Reply-To: <441542f15012666c621814327415a2cbb0960e10.camel@j-davis.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox