From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Recalculate search_path after ALTER ROLE.
Date: Thu, 10 Aug 2023 07:03:52 -0400
Message-ID: <88825.1691665432@sss.pgh.pa.us> (raw)
In-Reply-To: <441542f15012666c621814327415a2cbb0960e10.camel@j-davis.com>
References: <E1qTpps-001FmA-IW@gemulon.postgresql.org>
<d4bc331366068e9605d65bfe471687b4d32528d8.camel@j-davis.com>
<441542f15012666c621814327415a2cbb0960e10.camel@j-davis.com>
Jeff Davis <pgsql@j-davis.com> writes:
> On Wed, 2023-08-09 at 16:12 -0700, Jeff Davis wrote:
>> I'm not sure yet, but this looks like a possible pre-existing bug, or
>> some incorrect assumption I made in fa2e874946.
> Before my commit the behavior is the same. Here's a minimal repro
> ...
> Given that it works fine without parallel query, I'm inclined to call
> this a parallel query bug. The error is coming from RestoreGUCState().
Check. Seems like we need a way to restore the role GUC without
performing a catalog lookup. I'll bet there are comparable bugs
with search path, temp tablespace names, etc.
> That being said, the buildfarm is red after my commit, so unless
> someone sees a quick fix here, perhaps I should remove my isolation
> test? I don't want to revert my whole commit, because it seems correct
> and fixes a separate bug.
Yes, just remove the test case for now. It might or might not be
worth the trouble to put it back later.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, jdavis@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Recalculate search_path after ALTER ROLE.
In-Reply-To: <88825.1691665432@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox