From: Chao Li <li.evan.chao@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Jeff Davis <jdavis@postgresql.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().
Date: Sat, 29 Nov 2025 09:54:25 +0800
Message-ID: <4F65CCF2-9184-4D37-990E-C311E3425293@gmail.com> (raw)
In-Reply-To: <519380.1764362419@sss.pgh.pa.us>
References: <202511281759.7zxt6cjzikzx@alvherre.pgsql>
<519380.1764362419@sss.pgh.pa.us>
> On Nov 29, 2025, at 04:40, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
>> On 2025-Nov-26, Jeff Davis wrote:
>>> Inline pg_ascii_tolower() and pg_ascii_toupper().
>
>> I think this broke the CI on (some flavors of?) Windows. In
>> https://cirrus-ci.com/task/6080935063453696
>> I got
>
>> [19:09:39.518] C:/msys64/ucrt64/bin/../lib/gcc/x86_64-w64-mingw32/15.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: src/backend/postgres_lib.a.p/commands_event_trigger.c.obj: in function `filter_list_to_array':
>> [19:09:39.518] c:\cirrus\build/../src/backend/commands/event_trigger.c:377:(.text+0x2a5): undefined reference to `pg_ascii_toupper'
>
> That's bizarre. I checked recent cfbot rebuilds of some of my patches
> and there's no problem, also just looking at port.h it's impossible
> to see how this could happen. Some weird compiled-code caching
> misbehavior in CI, perhaps?
>
> regards, tom lane
>
>
ec4997a moved the two functions from pgstrcasecmp.c to port.h and made them inline, so maybe some old .o were not rebuilt and still need to link to the old functions.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: li.evan.chao@gmail.com, tgl@sss.pgh.pa.us, alvherre@kurilemu.de, jdavis@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Inline pg_ascii_tolower() and pg_ascii_toupper().
In-Reply-To: <4F65CCF2-9184-4D37-990E-C311E3425293@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox