From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Date: Sun, 17 Jul 2022 22:34:42 -0400
Message-ID: <532024.1658111682@sss.pgh.pa.us> (raw)
In-Reply-To: <20220718020155.s2soi3niln2skjwi@awork3.anarazel.de>
References: <E1oDFCt-0001nT-LO@gemulon.postgresql.org>
<20220718013934.27ukvatuxneyrr2v@awork3.anarazel.de>
<20220718020155.s2soi3niln2skjwi@awork3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
> I don't know how the configure exec bit got removed, shell history doesn't
> show anything odd in that regard. I do see a mistake in locally merging the
> symbol-visibility branch (leading to a crucial commit being missed). I do see
> in shell history that I ran check-world without a failure just before pushing,
> which should have shown the failure, but didn't.
check-world would not have re-run configure even if it was out of date
(only config.status), so that part of it's not so surprising.
> Definitely a brown paper bag moment.
We've all been there :-)
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
In-Reply-To: <532024.1658111682@sss.pgh.pa.us>
References: <E1oDFCt-0001nT-LO@gemulon.postgresql.org> <20220718013934.27ukvatuxneyrr2v@awork3.anarazel.de> <20220718020155.s2soi3niln2skjwi@awork3.anarazel.de> <532024.1658111682@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox