From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke
Date: Mon, 03 Jun 2019 21:16:56 -0400
Message-ID: <54159.1559611016@sss.pgh.pa.us> (raw)
In-Reply-To: <20190604011354.GD1529@paquier.xyz>
References: <E1hXv5x-0002VX-HF@gemulon.postgresql.org>
<20190604011354.GD1529@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Jun 03, 2019 at 10:06:21PM +0000, Tom Lane wrote:
>> Fix contrib/auto_explain to not cause problems in parallel workers.
> This has broken the builds on Windows for 9.6 and 10:
> https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=woodlouse&dt=2019-06-04%2000%3A42%...
Ooops.
> This gets included as a dependency because of the call to
> IsParallelWorker() you have added in this commit, and I think that
> this can be fixed by adding PGDLLIMPORT to the variable in
> parallel.h. Would you fix it or should I?
Yeah, I see we already did that in later branches. I'll go fix it,
thanks for the heads-up!
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix contrib/auto_explain to not cause problems in parallel worke
In-Reply-To: <54159.1559611016@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox